[Enhancement] Default naming of OpenHome renderer #356 (#357)

GioF71 · Dec 19, 2023 · 4c4e3cc · 4c4e3cc
1 parent 0748dc0
commit 4c4e3cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/bin/run-upmpdcli.sh b/app/bin/run-upmpdcli.sh
@@ -228,7 +228,11 @@ fi
 # Friendly name management
 if [ -n "${FRIENDLY_NAME}" ]; then
     echo "FRIENDLY_NAME=[${FRIENDLY_NAME}], UPNPAV_SKIP_NAME_POSTFIX=[${UPNPAV_SKIP_NAME_POSTFIX}]"
-    UPMPD_FRIENDLY_NAME="${FRIENDLY_NAME}"
+    if [[ -z "${UPMPD_FRIENDLY_NAME}" ]] && [[ $OPENHOME -eq 1 && $UPNPAV -eq 1 ]]; then
+        UPMPD_FRIENDLY_NAME="${FRIENDLY_NAME} (oh)"
+    else
+        UPMPD_FRIENDLY_NAME="${FRIENDLY_NAME}"
+    fi
     echo "UPMPD_FRIENDLY_NAME=[${UPMPD_FRIENDLY_NAME}]"
     if [[ -z "${UPNPAV_SKIP_NAME_POSTFIX}" || "${UPNPAV_SKIP_NAME_POSTFIX^^}" == "YES" ]] && 
           [ "${OPENHOME}" -eq 0 ] && 

diff --git a/doc/change-history.md b/doc/change-history.md
@@ -2,6 +2,7 @@
 
 Change Date|Major Changes
 ---|---
+2023-12-19|Default naming of oh renderer (see [#356](https://github.com/GioF71/upmpdcli-docker/issues/356)) 
 2023-12-16|Dropped support for Deezer (see [#353](https://github.com/GioF71/upmpdcli-docker/issues/353))
 2023-12-11|Support `prependnumberinitemlist` for Tidal (see issue [#351](https://github.com/GioF71/upmpdcli-docker/issues/351))
 2023-11-29|Dropped bullseye and mantic builds (see issue [#348](https://github.com/GioF71/upmpdcli-docker/issues/348))