Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notify reward script for gnosis, optimism, zkevm sep 2024 #103

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add notify reward script for gnosis, optimism, zkevm sep 2024 #103

merged 1 commit into from
Aug 29, 2024

Conversation

mohammadranjbarz
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz commented Aug 25, 2024 •
edited
Loading

aminlatifi
aminlatifi reviewed Aug 28, 2024
View reviewed changes
deployments/notifyRewardAmount/optimism/givpower_distribute_extended_sep_2024.js
const pos = Math.floor((currentTime - initTime) / duration);
console.log("pos:", pos);
if (pos < 0) return;
if (distro[pos] === 0) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?! in purpose?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?! in purpose?

I just used the last notifyReward script and changed the params and addresses, .. , didn't change the code logic, WDYT should we delete it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have put that condition in place due to some special situation we had with optimism. If the current OP rewarding program ends around the the start of the new program, we don't need that condition.

@aminlatifi
Copy link
Member

@mohammadranjbarz Don't forget to set the reward notifier on the zkevm unipool.

aminlatifi
aminlatifi approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@aminlatifi aminlatifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mohammadranjbarz

@mohammadranjbarz
Copy link
Collaborator Author

mohammadranjbarz commented Aug 29, 2024 •
edited
Loading

@mohammadranjbarz Don't forget to set the reward notifier on the zkevm unipool.

@aminlatifi
I just changed the reward distribution of polygon zkevm unipool givPower https://zkevm.polygonscan.com/address/0xc790f82bf6f8709aa4a56dc11afad7af7c2a9867#readProxyContract to what is the reward distribution for unipool givPower on gnosis smart contract https://gnosisscan.io/address/0xD93d3bDBa18ebcB3317a57119ea44ed2Cf41C2F2#readProxyContract

FYI @laurenluz

@mohammadranjbarz mohammadranjbarz merged commit 5188586 into main Aug 29, 2024
1 check passed
@mohammadranjbarz mohammadranjbarz deleted the 4434_adjust_notify_reward_sep_2024 branch August 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminlatifi aminlatifi aminlatifi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadranjbarz @aminlatifi