sending email for notify reward amount #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae2079
commented
Jun 18, 2024
ae2079
commented
Jun 20, 2024
|
|
||
| const NotifyRewardAmountNotificationType = [ | ||
| { | ||
| name: NOTIFICATION_TYPE_NAMES.NOTIFY_REWARD_AMOUNT, |
There was a problem hiding this comment.
@mohammadranjbarz
I ran the migration and these fields are set successfully, but I am not sure about the correctness of their values and I don't know if I should put other fields too, or not
mohammadranjbarz
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Thanks @ae2079, LGTM (we can merge it once we can test it together after deployment)
Done, thank you Ramin |
RamRamez
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fields for the notify reward amount notification from giv-token-contracts service
related to: Giveth/giveth-dapps-v2#4194