Separate Test & Deploy steps in Travis. #617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipakmdhrm
changed the title
bboro
reviewed
Jan 12, 2024
| - "(travis_retry $TRAVIS_BUILD_DIR/ci-scripts/prepare_deploy.sh) || travis_terminate 1;" | ||
| - "(travis_retry ddev robo deploy:tag-pantheon --no-interaction $TRAVIS_TAG master) || travis_terminate 1;" | ||
| - "ddev composer install || travis_terminate 1;" | ||
| - "(travis_retry ddev robo deploy:pantheon-sync) || travis_terminate 1;" | ||
| - stage: Deploy | ||
| name: 'Backend tests: Functional tests and deploy to Pantheon LIVE' | ||
| name: 'Backend tests: Deploy to Pantheon LIVE' | ||
| if: tag IS present AND type = "push" AND tag =~ /live$/ | ||
| script: | ||
| - "$TRAVIS_BUILD_DIR/ci-scripts/check_live_deploy.sh || travis_terminate 1;" | ||
| - "(travis_retry $TRAVIS_BUILD_DIR/ci-scripts/install_ddev.sh) || travis_terminate 1;" | ||
| - "$TRAVIS_BUILD_DIR/ci-scripts/install_drupal.sh || travis_terminate 1;" |
There was a problem hiding this comment.
Do we still need to install drupal if we're not running tests in this step*?
|
It was an optimization idea to save time. Initializing the project takes time (downloading Docker images, etc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Sometimes during deployment, the build passes all tests but the deployment fails due to some issue in git, redis, etc. In such cases, to trigger the deployment, we need to re-run the whole test+deploy.
This will allow us to re-trigger deployment without re-running tests.