Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix translator role issues #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: Fix translator role issues #620

wants to merge 2 commits into from

Conversation

mgurjanov
Copy link
Collaborator

When we have a translator role that doesn't have edit permissions we encounter two translation issues that this PR fixes:

  1. Referenced Paragraph cannot be accessed for translation
  2. Media library introduced edit permission check that pure translator role shouldn't have (such translator role is able to only add/update translations and not to edit source node and this is supported by Drupal core). This permission check for such translator role, results in AJAX error which the applied fix prevents and allows a media entity to be changed/translated in translated node.

@mgurjanov mgurjanov requested a review from amitaibu January 13, 2024 00:38
@amitaibu
Copy link
Member

Thanks. Can you please add test(s) to validate?

@amitaibu amitaibu changed the title Fix translator role issues WIP: Fix translator role issues Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitaibu amitaibu Awaiting requested review from amitaibu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgurjanov @amitaibu