Added rollbar configuration #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
reviewed
Mar 4, 2024
| // Rollbar settings for LIVE and TEST. | ||
| if ($pantheon_env == 'live' || $pantheon_env == 'test') { | ||
| $config['rollbar.environment'] = $pantheon_site_name . '.' . $pantheon_env; | ||
| $config['rollbar.enabled'] = TRUE; |
There was a problem hiding this comment.
Here we would also have the access token of rollbar right? If so, let's add a placeholder
There was a problem hiding this comment.
No. Access token is saved in the module's config file, but there is a setting which disables the module, here we just enable it.
amitaibu
reviewed
Mar 4, 2024
amitaibu
reviewed
Mar 5, 2024
README.md
Outdated
|
|
||
| ### Rollbar configuration | ||
|
|
||
| Rollbar will be automatically enabled on test and live environments. The access tokens need to be added and the rollbar configuration yml file should be committed. |
There was a problem hiding this comment.
Please provide the link /admin/... for the settings
README.md
Outdated
| @@ -213,6 +213,12 @@ and you can see the test running in the browser. | |||
| Check the [DDEV documentation](https://ddev.readthedocs.io/en/latest/users/debugging-profiling/step-debugging/) | |||
| if you are using other IDE or want to know more about this feature. | |||
|
|
|||
| ## Prepare for Deployment | |||
|
|
|||
| ### Rollbar configuration | |||
There was a problem hiding this comment.
Let's move it under Deploy to Pantheon and remove Prepare for Deployment
amitaibu
reviewed
Mar 10, 2024
README.md
Outdated
| @@ -215,6 +215,10 @@ if you are using other IDE or want to know more about this feature. | |||
|
|
|||
| ## Deploy to Pantheon | |||
|
|
|||
| ### Rollbar configuration | |||
|
|
|||
| Rollbar will be automatically enabled on test and live environments. The access tokens need to be added under '/admin/config/services/rollbar' and the rollbar configuration yml file should be committed. | |||
There was a problem hiding this comment.
Actually, instead of /admin/config/services/rollbar - can't we have the setting placeholder on settings.pantheon.php?
AronNovak
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#634