Add ddev robo cache:disable|enable #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AronNovak
reviewed
Sep 6, 2024
| @@ -71,4 +84,186 @@ public function __construct() { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Helper to get settings.local.php file. | |||
There was a problem hiding this comment.
Put all these into a trait, let's say DevelopmentTrait under robo-components. We decided to keep RoboFile minimal.
AronNovak
reviewed
Sep 6, 2024
| // Clear Drupal cache. | ||
| $this->taskExec('drush cr')->run(); | ||
|
|
||
| $this->say("Drupal caching disabled."); |
There was a problem hiding this comment.
We do some file manipulations only, I'd try to verify it programmatically if the changes are truly effective and this way, we could do some error handling. Like doing some HTTP requests and check the headers or try to retrieve the config bits via the API, then we could have a conditional branch where we explain what went wrong and set a non-zero exit code. Same for the other direction.
|
@amitaibu In order to address PR review suggestions I'd need a TB bump. |
|
Sure, Bump to 5h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#605
Note: I tested locally and I am getting cache HIT/MISS according to appropriate new command.
TB: 3.4