Rollbar integration #752
Merged
Rollbar integration #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the 1-1 port from client project. We can improve it as agreed in a follow-up. |
amitaibu
reviewed
Nov 14, 2024
| @@ -12,6 +12,7 @@ stages: | |||
| env: | |||
| global: | |||
| - DDEV_NO_INSTRUMENTATION=true | |||
| - ROLLBAR_SERVER_TOKEN=df6ce617465b4980afdecc95ed1b42de | |||
| - PANTHEON_GIT_URL="ssh://codeserver.dev.5acc1750-abf0-47ef-a6d8-6890a6efaca8@codeserver.dev.5acc1750-abf0-47ef-a6d8-6890a6efaca8.drush.in:2222/~/repository.git" | |||
There was a problem hiding this comment.
Off topic - now with the Codespace integration, we can probably remove the Pantheon.
There was a problem hiding this comment.
I guess it's more a PM question, if they need persistent demo stuff or not.
@isapisa @nora-novak
composer.patches.json
Outdated
| @@ -32,6 +32,9 @@ | |||
| }, | |||
| "drupal/seckit": { | |||
| "d.o. #3206728": "https://www.drupal.org/files/issues/2024-09-06/seckit-2_x-src-field-length-3206728-8.patch" | |||
| }, | |||
| "drupal/rollbar": { | |||
| "memory issues": "patches/3432364-rollbar-vars.patch" | |||
There was a problem hiding this comment.
amitaibu
reviewed
Nov 14, 2024
Co-authored-by: Amitai Burstein <[email protected]>
|
Needs a re-roll |
|
@AronNovak sorry, I merged a PR before, and it caused another conflict 😬 |
amitaibu
approved these changes
Dec 10, 2024
|
Thanks 🙏 sorry for all the back-and-forth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.