Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showJsError when developing. Update imagemin version. #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HelenaEksler
Copy link
Contributor

No description provided.

@HelenaEksler
Copy link
Contributor Author

@amitaibu Could you take a look? And maybe advice how to insert the script only on development.

@HelenaEksler HelenaEksler changed the title Add showJsError when developing. Update imagemin version. WIP: Add showJsError when developing. Update imagemin version. Mar 28, 2016
title: 'JavaScript error',
userAgent: navigator.userAgent,
sendText: 'Send',
sendUrl: 'https://github.com/skeleton/skeleton/issues/new?title={title}&body={body}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the github URL should be replaced upon yo hedley -- see other places where is happens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. I've forgot to change it after synchronization.

@amitaibu
Copy link
Member

And maybe advice how to insert the script only on development.

grunt serve should call this task, but grunt serve:dist/ grunt build should not.

@HelenaEksler
Copy link
Contributor Author

This I'm doing for including bower component. But how can I define for some custom script? Move it to the separate file? Or there is other way?

@amitaibu
Copy link
Member

separate file sounds right - but better google a bit how others are doing it.

@HelenaEksler
Copy link
Contributor Author

@amitaibu Ready for review.

@HelenaEksler HelenaEksler changed the title WIP: Add showJsError when developing. Update imagemin version. Add showJsError when developing. Update imagemin version. Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants