Merge pull request #96 from kevin-dutra/95-missing-delivery-candidates

#95 Missing subscriptions on delivery candidates when batched.
Gizra · Jun 7, 2017 · ec4f8d0 · ec4f8d0
2 parents 834f3cb + 890c7cf
commit ec4f8d0
Showing 1 changed file with 56 additions and 31 deletions.
diff --git a/message_subscribe.module b/message_subscribe.module
@@ -28,6 +28,16 @@ function message_subscribe_message_subscribe_get_subscribers(MessageInterface $m
     ['@context' => "\n\n" . print_r($context, TRUE)]
   );
 
+  // Query all the entity IDs inside the given flags. We don't use
+  // flag_get_content_flags() as we want to get all the flaggings of an
+  // entity-type in a single query.
+  $query = \Drupal::database()->select('flagging', 'fc')
+    ->fields('fc', ['flag_id', 'uid', 'entity_id', 'uid']);
+  $query->condition('fc.uid', $subscribe_options['last uid'], '>');
+  $query->orderBy('fc.uid', 'ASC');
+
+  $flagging_condition = $query->orConditionGroup();
+
   // Find the users that subscribed to each context.
   foreach ($context as $entity_type => $entity_ids) {
     if (!$entity_ids) {
@@ -40,48 +50,63 @@ function message_subscribe_message_subscribe_get_subscribers(MessageInterface $m
     }
 
     $debug && \Drupal::logger('message_subscribe')->debug(
-      'Using flags @flags for @entity_type @entity_ids for users greater than id @uid',
+      'Using flags @flags for @entity_type @entity_ids',
       [
         '@flags' => implode(', ', array_keys($flags)),
         '@entity_type' => $entity_type,
         '@entity_ids' => implode(', ', $entity_ids),
-        '@uid' => $subscribe_options['last uid'],
       ]
     );
 
-    // Query all the entity IDs inside the given flags. We don't use
-    // flag_get_content_flags() as we want to get all the flaggings of an
-    // entity-type in a single query.
-    $query = \Drupal::database()->select('flagging', 'fc')
-      ->fields('fc', ['flag_id', 'uid'])
-      ->condition('fc.entity_type', $entity_type)
-      ->condition('fc.entity_id', $entity_ids, 'IN')
-      ->condition('fc.flag_id', array_keys($flags), 'IN')
-      ->condition('fc.uid', $subscribe_options['last uid'], '>')
-      ->orderBy('fc.uid', 'ASC');
-
-    if ($range) {
-      $query->range(0, $range);
-      // If we're mpt notifying blocked users, we need to take this into account
-      // in this query so that the range is accurate.
-      if (empty($subscribe_options['notify blocked users'])) {
-        $query->join('users_field_data', 'users', 'users.uid = fc.uid');
-        $query->condition('users.status', '1');
-      }
-    }
+    $entity_type_condition = $query->andConditionGroup();
+    $entity_type_condition->condition('fc.entity_type', $entity_type);
+    $entity_type_condition->condition('fc.entity_id', $entity_ids, 'IN');
+    $entity_type_condition->condition('fc.flag_id', array_keys($flags), 'IN');
+    $flagging_condition->condition($entity_type_condition);
+  }
 
-    $result = $query->execute();
+  // If none of the subscription types ended up being valid, then no users
+  // should be returned.
+  if (count($flagging_condition->conditions()) < 1) {
+    return [];
+  }
+
+  $query->condition($flagging_condition);
 
-    foreach ($result as $row) {
-      $debug && \Drupal::logger('message_subscribe')->debug(
-        'Subscriber row flag_id: @flag_id user: @uid',
-        ['@flag_id' => $row->flag_id, '@uid' => $row->uid]
-      );
-      $uids[$row->uid] = !empty($uids[$row->uid]) ? $uids[$row->uid] : new DeliveryCandidate([], [], $row->uid);
-      // Register the flag name.
-      $uids[$row->uid]->addFlag($row->flag_id);
+  if ($range) {
+    $user_query = \Drupal::database()->select('flagging', 'fc')
+      ->distinct()
+      ->fields('fc', ['uid']);
+    $user_query->condition($flagging_condition);
+    $user_query->condition('fc.uid', $subscribe_options['last uid'], '>');
+    $user_query->range(0, $range);
+
+    // If we're not notifying blocked users, we need to take this into account
+    // in this query so that the range is accurate.
+    if (empty($subscribe_options['notify blocked users'])) {
+      $user_query->join('users_field_data', 'users', 'users.uid = fc.uid');
+      $user_query->condition('users.status', '1');
+    }
+    $users = $user_query->execute()->fetchCol();
+
+    // Limit the flagging results to only this subset of users.
+    if (!empty($users)) {
+      $query->condition('fc.uid', $users, 'IN');
     }
   }
+
+  $result = $query->execute();
+
+  foreach ($result as $row) {
+    $debug && \Drupal::logger('message_subscribe')->debug(
+      'Subscriber row flag_id: @flag_id user: @uid',
+      ['@flag_id' => $row->flag_id, '@uid' => $row->uid]
+    );
+    $uids[$row->uid] = !empty($uids[$row->uid]) ? $uids[$row->uid] : new DeliveryCandidate([], [], $row->uid);
+    // Register the flag name.
+    $uids[$row->uid]->addFlag($row->flag_id);
+  }
+
   $debug && \Drupal::logger('message_subscribe')->debug(
     'Found @count recipients.',
     ['@count' => count($uids)]