Apply suggestions from code review

Co-authored-by: Damien McKenna <[email protected]>

og.module

@@ -160,7 +160,6 @@ function og_entity_access(EntityInterface $entity, $operation, AccountInterface
   if (count($audience_fields) === 1) {
     $field_definitions = \Drupal::service('entity_field.manager')->getFieldDefinitions($entity_type_id, $bundle_id);
     foreach ($field_definitions as $field_definition) {
-
       /** @var \Drupal\Core\Field\FieldDefinitionInterface $field_definition */
       if (!in_array($field_definition->getName(), array_keys($audience_fields))) {
         continue;
@@ -248,7 +247,7 @@ function og_entity_create_access(AccountInterface $account, array $context, $bun
     $handler = \Drupal::service('plugin.manager.entity_reference_selection');
     $handler = $handler->getInstance($options);
 
-    // @todo: remove deprecated call to Og::getSelectionHandler.
+    // @todo Remove deprecated call to Og::getSelectionHandler.
     $handler = Og::getSelectionHandler($field_definition);
 
     if ($handler && $handler->countReferenceableEntities()) {
@@ -347,7 +346,6 @@ function og_field_widget_info_alter(array &$info) {
  * be rebuilt via RouteBuilder::setRebuildNeeded.
  */
 function og_entity_type_alter(array &$entity_types) {
-
   /** @var \Drupal\Core\Entity\EntityTypeInterface $entity_type */
   foreach ($entity_types as $entity_type_id => $entity_type) {
 

src/Plugin/EntityReferenceSelection/OgSelection.php

@@ -168,7 +168,7 @@ protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS')
     }
 
     if (empty($this->configuration['entity'])) {
-      // @todo: Find out why we have this scenario.
+      // @todo Find out why we have this scenario.
       return $query;
     }
 
@@ -222,7 +222,6 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
     $bundles_info = $this->entityTypeBundleInfo->getBundleInfo($entity_type_id);
 
     if ($entity_type->hasKey('bundle')) {
-
       $bundles = Og::groupTypeManager()->getGroupBundlesByEntityType($entity_type_id);
       foreach ($bundles as $bundle) {
         $bundle_options[$bundle] = $bundles_info[$bundle]['label'];

tests/src/Functional/OgSelectionWidgetOptionsTest.php

@@ -45,7 +45,6 @@ class OgSelectionWidgetOptionsTest extends BrowserTestBase {
    */
   protected $group2;
 
-
   /**
    * An unpublished group node.
    *
@@ -162,7 +161,7 @@ public function testNonRequiredAudienceField() {
     $this->drupalGet('node/add/group_content');
     // The user can't post group content site wide so the audience is required
     // field.
-    // todo: is that correct?
+    // todo Is that correct?
     // $this->assertSession()->optionExists('Groups audience', '_none');.
     $this->assertSession()->optionExists('Groups audience', $this->group1->label());
     $this->assertSession()->optionNotExists('Groups audience', $this->group2->label());