This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] OG Access port #242
[WIP] OG Access port #242
Changes from 35 commits
1bfdfe9
18ab411
72451e1
f08fe78
3a77001
5e1436c
5a801ab
690235a
d3c36c3
f1dc41b
98f0c38
202c31c
ac43c9d
4cf5b4b
66cbcbf
50fde53
40acefa
645f40a
babf336
71f636f
7e0b216
eb548eb
4ab462a
3b63ae7
60197b6
1342e72
29de2b3
4ed5950
dc3eb79
39925fb
14f23d3
1ab9466
67dd034
127db3a
ebace9d
57f47d0
e635a75
a8389e9
d59a0ee
d64c11d
246aadd
208c0a3
fec3974
2887506
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this property and argument since StringTranslationTrait is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to inject the service, the trait doesn't do this (it would work but then the trait would get the service from the global container).
There is an api to set the service though:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice earlier that we're instantiating OgAccessBundleFormAlter from within a hook_form_alter.
As we are injecting the service from the global container we might as well remove the Trait, or keep it as we might move to events instead of hooks in the future...