This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Provide "delete" entity operation access check on group entities #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be more easily extendable.
pfrenssen
force-pushed
the
group-entity-operation-access
branch
from
05633f9 to
06ddf71
Compare
… this with a test for group entity operation permissions.
pfrenssen
force-pushed
the
group-entity-operation-access
branch
from
ca32686 to
bdbde6a
Compare
This was referenced Aug 2, 2020
pfrenssen
changed the title
|
#673 has been merged, this is now ready for review. |
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
reviewed
Aug 3, 2020
MPParsley
approved these changes
Aug 3, 2020
Co-authored-by: Maarten Segers <[email protected]>
Co-authored-by: Maarten Segers <[email protected]>
|
Solved all the remarks, I assume this is good to go now since it has been approved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674
This is building on top of #673 as part of the OgAccess refactoring.