Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Drop custom cache handling #729

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Drop custom cache handling #729

merged 2 commits into from
Dec 17, 2021

Conversation

AronNovak
Copy link
Member

@AronNovak AronNovak requested a review from pfrenssen November 5, 2021 17:33
@AronNovak AronNovak changed the title WIP: Drop custom cache handling Drop custom cache handling Nov 5, 2021
@pfrenssen
Copy link
Contributor

I would like to run this against a big project I am working on at the European Commission. We have a whole bunch of dedicated cache contexts and tests to check caching on pages that display groups and group content. I cannot do this right now though since we are still on an older version of OG, but I hope to be able to do this in the near future. I will report back here.

@pfrenssen
Copy link
Contributor

I started a test on our (unfortunately private) gitlab instance: https://git.fpfis.eu/digit/digit-joinup-dev/-/merge_requests/111

I will report back here with the results.

@pfrenssen
Copy link
Contributor

Test has passed on our OG based project!

Thanks a lot for this great cleanup!

@pfrenssen pfrenssen merged commit 268e9f4 into Gizra:8.x-1.x Dec 17, 2021
@AronNovak AronNovak deleted the 687-og-cache branch December 17, 2021 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfrenssen pfrenssen pfrenssen approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AronNovak @pfrenssen