-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #409 and #407 #410
Conversation
adehecq
commented
Oct 20, 2023
•
edited
Loading
edited
- solves Raster.show() does not always function as expected #407
- solves Reproject fails with error when self.res contains numpy floats #409
A bit afraid that the plotting changes will break examples in the documentation, as this is why this code was modified in the first place. Before merging, we should check how the documentation renders on your fork @adehecq (you need to go to readthedocs and build the branch on your fork, can give more details if you haven't done that before) |
Right now, I fail building the documentation on readthedocs for this branch... But this does not seem to be related to the change to plots are undoing it did not solve the issue. |
Strange, because the documentation of the |
Ok, now the doc compiled (I don't know why it was not working before but now it does...). |
Indeed, I couldn't find any figure that looked different! 🥳 Let's remember to check every page of the doc before we release a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for looking into this!