Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #409 and #407 #410

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix for issue #409 and #407 #410

merged 5 commits into from
Jan 16, 2024

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Oct 20, 2023

@rhugonnet
Copy link
Member

A bit afraid that the plotting changes will break examples in the documentation, as this is why this code was modified in the first place. Before merging, we should check how the documentation renders on your fork @adehecq (you need to go to readthedocs and build the branch on your fork, can give more details if you haven't done that before)

@adehecq adehecq changed the title Fix for issue #409 Fix for issue #409 and #407 Dec 20, 2023
@adehecq
Copy link
Member Author

adehecq commented Dec 21, 2023

Right now, I fail building the documentation on readthedocs for this branch... But this does not seem to be related to the change to plots are undoing it did not solve the issue.

@rhugonnet
Copy link
Member

Strange, because the documentation of the main branch is still passing (restarted a build today to try): https://readthedocs.org/projects/geoutils/builds/22932914/

@adehecq
Copy link
Member Author

adehecq commented Jan 15, 2024

Ok, now the doc compiled (I don't know why it was not working before but now it does...).
Here is the link: https://geoutils-adehecq.readthedocs.io/en/amaury_fixes/index.html.
@rhugonnet, where did you expect the changes to break the doc? I looked at a few figures and they appeared as expected.

@rhugonnet
Copy link
Member

rhugonnet commented Jan 16, 2024

Indeed, I couldn't find any figure that looked different! 🥳
I was expecting two-panel figures to be difference, as you are now getting the current axis, not necessarily the first one of a figure. But maybe it's better this way anyway ;)

Let's remember to check every page of the doc before we release a 0.1 after the hackathon!

Copy link
Member

@rhugonnet rhugonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for looking into this!

@adehecq adehecq merged commit 3e45720 into GlacioHack:main Jan 16, 2024
13 checks passed
@adehecq adehecq deleted the amaury_fixes branch January 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants