-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix issue with doc building on Mac/Windows #436
Conversation
Should I disable tests for Windows then? Or we should have someone test it locally on a Windows to understand the issue... |
Talk about a useless message, It also says "Theme error" right next to it. We can unfix it now because Sphinx book theme just released a new version that works with the new Pydata theme: https://github.com/executablebooks/sphinx-book-theme/releases, and apparently fixes a lot of bugs. If the rendering is good, it would also solve issue GlacioHack/xdem#452 once mirrored in xDEM! 🙂 |
And otherwise yes, we should probably not lose time on this mysterious error and just skip Windows |
@rhugonnet, the test does not fail on Windows anymore after unfixing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! We're solving a lot of old problems :)
Pfff, after merging with the main branch, the doc build fails again on Windows. It seems related to the new CLI section. The path to the script |
Attempts to fix an issue only referenced on xdem: GlacioHack/xdem#316.
test_doc.py
for Mac -> The test now passes ! 🥳 (I'm not sure if it's related to my change or it was fixed earlier).Raised issue #442 for the Windows problem.