Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip install and add more exhaustive CI checks #593

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

rhugonnet
Copy link
Member

@rhugonnet rhugonnet commented Aug 2, 2024

This PR removes fiona as a dependency of GeoUtils as it was also dropped by GeoPandas in favor of pyogrio (which was breaking the pip install, and probably would have eventually broken the conda one as well).

This PR also adds a new (fast) CI action that simply checks that the pip install works and can import the package (usually runs in less than 2min), so that we immediately find out about these issues in the future before releasing.

Resolves #594

@rhugonnet rhugonnet merged commit 7484327 into GlacioHack:main Aug 2, 2024
19 checks passed
@rhugonnet rhugonnet deleted the fix_pip_install branch August 2, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies after pip install
2 participants