Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move array types into rayexec_execution #3375

Merged
merged 3 commits into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ jobs:
- name: Standard tests
run: cargo test -- --skip slt_datasource_ --skip slt_tpch --skip slt_tpcds --skip slt_hybrid

- name: SLTs Hybrid
run: cargo test slt_hybrid
# TODO
# - name: SLTs Hybrid
# run: cargo test slt_hybrid

- name: SLTs Parquet
env:
Expand Down
17 changes: 3 additions & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/docgen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ rayexec_execution = { path = '../rayexec_execution' }
rayexec_server = { path = '../rayexec_server' }
rayexec_shell = { path = '../rayexec_shell' }
rayexec_rt_native = { path = '../rayexec_rt_native' }
rayexec_bullet = { path = '../rayexec_bullet' }
rayexec_postgres = { path = '../rayexec_postgres' }
rayexec_parquet = { path = '../rayexec_parquet' }
rayexec_csv = { path = '../rayexec_csv' }
Expand Down
12 changes: 6 additions & 6 deletions crates/docgen/src/markdown_table.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
use std::fmt;

use rayexec_bullet::batch::Batch;
use rayexec_bullet::field::Schema;
use rayexec_bullet::format::{FormatOptions, Formatter};
use rayexec_error::Result;
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::field::Schema;
use rayexec_execution::arrays::format::{FormatOptions, Formatter};

const FORMATTER: Formatter = Formatter::new(FormatOptions {
null: "",
Expand Down Expand Up @@ -54,9 +54,9 @@ pub fn write_markdown_table<'a>(

#[cfg(test)]
mod tests {
use rayexec_bullet::array::Array;
use rayexec_bullet::datatype::DataType;
use rayexec_bullet::field::Field;
use rayexec_execution::arrays::array::Array;
use rayexec_execution::arrays::datatype::DataType;
use rayexec_execution::arrays::field::Field;

use super::*;

Expand Down
2 changes: 1 addition & 1 deletion crates/parquet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ rust-version = "1.70.0"

[dependencies]
rayexec_error = { path = "../rayexec_error" }
rayexec_bullet = { path = "../rayexec_bullet" }
rayexec_execution = { path = "../rayexec_execution" }
ahash = { workspace = true }
bytes = { version = "1.1", default-features = false, features = ["std"] }
thrift = { version = "0.17", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion crates/parquet/src/encodings/decoding/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
//! since that's hard to work with.

use bytes::Bytes;
use rayexec_bullet::executor::builder::{ArrayDataBuffer, GermanVarlenBuffer};
use rayexec_execution::arrays::executor::builder::{ArrayDataBuffer, GermanVarlenBuffer};

use super::Encoding;
use crate::encodings::rle::RleDecoder;
Expand Down
9 changes: 0 additions & 9 deletions crates/rayexec_bullet/src/bitutil.rs

This file was deleted.

15 changes: 0 additions & 15 deletions crates/rayexec_bullet/src/ipc/batch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,6 @@ use super::compression::CompressionType;
use super::gen::message::{FieldNode as IpcFieldNode, RecordBatch as IpcRecordBatch};
use super::gen::schema::Buffer as IpcBuffer;
use super::IpcConfig;
use crate::array::{Array, ArrayData, BinaryData};
use crate::batch::Batch;
use crate::bitmap::Bitmap;
use crate::bitutil::byte_ceil;
use crate::datatype::DataType;
use crate::executor::physical_type::PhysicalType;
use crate::field::Schema;
use crate::ipc::gen::message::RecordBatchBuilder;
use crate::scalar::interval::Interval;
use crate::storage::{
BooleanStorage,
GermanVarlenStorage,
PrimitiveStorage,
UnionedGermanMetadata,
};

pub fn ipc_to_batch(
batch: IpcRecordBatch,
Expand Down
10 changes: 5 additions & 5 deletions crates/rayexec_bullet/src/ipc/mod.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
//! Arrow IPC compatability.
//!
//! Spec: <https://arrow.apache.org/docs/format/Columnar.html#serialization-and-interprocess-communication-ipc>
pub mod stream;
// pub mod stream;

mod batch;
mod compression;
mod gen;
mod schema;
// mod batch;
// mod compression;
// mod gen;
// mod schema;

#[derive(Debug, Clone, Default)]
pub struct IpcConfig {}
17 changes: 0 additions & 17 deletions crates/rayexec_bullet/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,18 +1 @@
//! A suspiciously Arrow-like columnar storage implementation.
pub mod array;
pub mod batch;
pub mod bitmap;
pub mod compute;
pub mod datatype;
pub mod executor;
pub mod field;
pub mod format;
pub mod ipc;
pub mod row;
pub mod scalar;
pub mod selection;
pub mod storage;

pub mod testutil;

mod bitutil;
1 change: 0 additions & 1 deletion crates/rayexec_csv/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ edition.workspace = true
[dependencies]
rayexec_proto = { path = '../rayexec_proto' }
rayexec_execution = { path = '../rayexec_execution' }
rayexec_bullet = { path = '../rayexec_bullet' }
rayexec_error = { path = '../rayexec_error' }
rayexec_io = { path = '../rayexec_io' }
futures = { workspace = true }
Expand Down
4 changes: 2 additions & 2 deletions crates/rayexec_csv/src/copy_to.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use futures::future::BoxFuture;
use futures::FutureExt;
use rayexec_bullet::batch::Batch;
use rayexec_bullet::field::Schema;
use rayexec_error::Result;
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::field::Schema;
use rayexec_execution::execution::operators::sink::PartitionSink;
use rayexec_execution::functions::copy::CopyToFunction;
use rayexec_execution::runtime::Runtime;
Expand Down
2 changes: 1 addition & 1 deletion crates/rayexec_csv/src/datatable.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use std::fmt::{self, Debug};

use futures::future::BoxFuture;
use rayexec_bullet::batch::Batch;
use rayexec_error::Result;
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::runtime::Runtime;
use rayexec_execution::storage::table_storage::{
DataTable,
Expand Down
4 changes: 2 additions & 2 deletions crates/rayexec_csv/src/read_csv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ use std::sync::Arc;

use futures::future::BoxFuture;
use futures::{FutureExt, StreamExt};
use rayexec_bullet::datatype::DataTypeId;
use rayexec_bullet::scalar::OwnedScalarValue;
use rayexec_error::{RayexecError, Result};
use rayexec_execution::arrays::datatype::DataTypeId;
use rayexec_execution::arrays::scalar::OwnedScalarValue;
use rayexec_execution::database::DatabaseContext;
use rayexec_execution::expr;
use rayexec_execution::functions::table::{
Expand Down
21 changes: 13 additions & 8 deletions crates/rayexec_csv/src/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,20 @@ use std::fmt;
use bytes::Bytes;
use futures::stream::BoxStream;
use futures::StreamExt;
use rayexec_bullet::array::{Array, ArrayData};
use rayexec_bullet::batch::Batch;
use rayexec_bullet::bitmap::Bitmap;
use rayexec_bullet::compute::cast::parse::{BoolParser, Float64Parser, Int64Parser, Parser};
use rayexec_bullet::datatype::{DataType, TimeUnit, TimestampTypeMeta};
use rayexec_bullet::executor::builder::{ArrayDataBuffer, GermanVarlenBuffer};
use rayexec_bullet::field::{Field, Schema};
use rayexec_bullet::storage::{BooleanStorage, PrimitiveStorage};
use rayexec_error::{RayexecError, Result};
use rayexec_execution::arrays::array::{Array, ArrayData};
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::bitmap::Bitmap;
use rayexec_execution::arrays::compute::cast::parse::{
BoolParser,
Float64Parser,
Int64Parser,
Parser,
};
use rayexec_execution::arrays::datatype::{DataType, TimeUnit, TimestampTypeMeta};
use rayexec_execution::arrays::executor::builder::{ArrayDataBuffer, GermanVarlenBuffer};
use rayexec_execution::arrays::field::{Field, Schema};
use rayexec_execution::arrays::storage::{BooleanStorage, PrimitiveStorage};
use rayexec_io::FileSource;
use serde::{Deserialize, Serialize};

Expand Down
6 changes: 3 additions & 3 deletions crates/rayexec_csv/src/writer.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
use std::io::Write as _;

use csv::ByteRecord;
use rayexec_bullet::batch::Batch;
use rayexec_bullet::field::Schema;
use rayexec_bullet::format::{FormatOptions, Formatter};
use rayexec_error::{Result, ResultExt};
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::field::Schema;
use rayexec_execution::arrays::format::{FormatOptions, Formatter};

use crate::reader::DialectOptions;

Expand Down
1 change: 0 additions & 1 deletion crates/rayexec_debug/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ edition.workspace = true
[dependencies]
rayexec_proto = { path = '../rayexec_proto' }
rayexec_execution = { path = '../rayexec_execution' }
rayexec_bullet = { path = '../rayexec_bullet' }
rayexec_error = { path = '../rayexec_error' }
rayexec_io = { path = '../rayexec_io' }
futures = { workspace = true }
Expand Down
4 changes: 2 additions & 2 deletions crates/rayexec_debug/src/discard.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use futures::future::BoxFuture;
use rayexec_bullet::batch::Batch;
use rayexec_bullet::field::Schema;
use rayexec_error::Result;
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::field::Schema;
use rayexec_execution::execution::operators::sink::PartitionSink;
use rayexec_execution::functions::copy::CopyToFunction;
use rayexec_io::location::FileLocation;
Expand Down
2 changes: 1 addition & 1 deletion crates/rayexec_debug/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ use std::sync::Arc;

use discard::DiscardCopyToFunction;
use futures::future::BoxFuture;
use rayexec_bullet::scalar::OwnedScalarValue;
use rayexec_error::{RayexecError, Result};
use rayexec_execution::arrays::scalar::OwnedScalarValue;
use rayexec_execution::database::catalog_entry::TableEntry;
use rayexec_execution::database::memory_catalog::MemoryCatalog;
use rayexec_execution::datasource::{DataSource, DataSourceConnection, DataSourceCopyTo};
Expand Down
4 changes: 2 additions & 2 deletions crates/rayexec_debug/src/table_storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ use std::sync::Arc;

use futures::future::BoxFuture;
use parking_lot::Mutex;
use rayexec_bullet::batch::Batch;
use rayexec_bullet::field::Field;
use rayexec_error::{RayexecError, Result};
use rayexec_execution::arrays::batch::Batch;
use rayexec_execution::arrays::field::Field;
use rayexec_execution::database::catalog_entry::CatalogEntry;
use rayexec_execution::execution::operators::sink::PartitionSink;
use rayexec_execution::storage::table_storage::{
Expand Down
1 change: 0 additions & 1 deletion crates/rayexec_delta/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ edition.workspace = true
[dependencies]
rayexec_proto = { path = '../rayexec_proto' }
rayexec_execution = { path = '../rayexec_execution' }
rayexec_bullet = { path = '../rayexec_bullet' }
rayexec_error = { path = '../rayexec_error' }
rayexec_io = { path = '../rayexec_io' }
rayexec_parquet = { path = '../rayexec_parquet' }
Expand Down
Loading
Loading