This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Helpbutton #100
Open
Helpbutton #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] Roadmap 1
hammydown4325
suggested changes
Feb 23, 2018
| @@ -147,6 +147,12 @@ function pokemonFilterImages($noPokemonNumbers) | |||
| title="PayPal - The safer, easier way to pay online!" alt="Donate" style="float: right;"> | |||
| </a>'; | |||
| } | |||
| if ($helplink != "") { | |||
There was a problem hiding this comment.
Change this to if (!empty($helplink)) {
| @@ -147,6 +147,12 @@ function pokemonFilterImages($noPokemonNumbers) | |||
| title="PayPal - The safer, easier way to pay online!" alt="Donate" style="float: right;"> | |||
| </a>'; | |||
| } | |||
| if ($helplink != "") { | |||
| echo '<a href="' . $helplink . '" target="_blank" style="margin-bottom: 5px; vertical-align: middle; padding:0 5px;"> | |||
There was a problem hiding this comment.
Move CSS style into one of the SCSS files.
There was a problem hiding this comment.
@iroken222 I copied and pasted this from the paypalurl/discordurl above it, do you want me to move those into stylesheets as well so they can be consistent?
| if ($helplink != "") { | ||
| echo '<a href="' . $helplink . '" target="_blank" style="margin-bottom: 5px; vertical-align: middle; padding:0 5px;"> | ||
| <img src="static/images/help.png" border="0" name="submit" | ||
| title="Help for this map." alt="Help" style="float: right;"> |
There was a problem hiding this comment.
Move styles into stylesheets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to give us an option to create a help page or video for users to help explain how the map works.