Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check cpu architecture and OS for gnparser binary (close #31) #32

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dimus
Copy link
Member

@dimus dimus commented Oct 28, 2024

No description provided.

@dimus dimus requested a review from LocoDelAssembly October 28, 2024 21:53
@LocoDelAssembly
Copy link
Contributor

Perhaps it is best to match by platform? Windows build failed. Here are possible platforms based on nokogiri: https://rubygems.org/gems/nokogiri/versions

Also would make a step closer to #31

To get the platform I think there is a global constant RUBY_PLATFORM for that. At least seems available in irb.

GitHub doesn't seem to have arm runners yet so we won't be able to verify with CI unless we can run QEMU or something as part of the test.

@dimus
Copy link
Member Author

dimus commented Oct 29, 2024

hm I get:

irb(main):002> ENV['PLATFORM']
=> nil

Let me try with RUBY_PLATFORM (looks like for JRuby RUBY_PLATFORM is always 'Java'

Also checking for platform creates a lot of possible combinations, because platform names are not standardized :-/
(eg aarch64-linux on mac, arm-linux-gnueabihf on Pi are both arm linux)

@dimus dimus merged commit 3420337 into master Oct 29, 2024
18 checks passed
@dimus dimus deleted the 31-os-cpu branch October 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants