Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message on invalid component #249

Merged
merged 1 commit into from
Nov 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/cli.ex
Original file line number Diff line number Diff line change
@@ -10,9 +10,12 @@ defmodule Onigumo.CLI do
strict: [working_dir: :string]
) do
{switches, [component], []} ->
{:ok, module} = Map.fetch(@components, String.to_atom(component))
working_dir = Keyword.get(switches, :working_dir, File.cwd!())
module.main(working_dir)
with {:ok, module} <- Map.fetch(@components, String.to_atom(component)) do
working_dir = Keyword.get(switches, :working_dir, File.cwd!())
module.main(working_dir)
else
:error -> usage_message()
end

_ ->
usage_message()
2 changes: 1 addition & 1 deletion test/onigumo_cli_test.exs
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ defmodule OnigumoCLITest do
describe("Onigumo.CLI.main/1") do
for argument <- @invalid_arguments do
test("run CLI with invalid argument #{inspect(argument)}") do
assert_raise(MatchError, fn -> Onigumo.CLI.main([unquote(argument)]) end)
assert usage_message_printed?(fn -> Onigumo.CLI.main([unquote(argument)]) end)
end
end


Unchanged files with check annotations Beta

"http://onigumo.local/hello.html",
"http://onigumo.local/bye.html"
]
@slices [0..1, 0..-1]

Check warning on line 9 in test/onigumo_downloader_test.exs

GitHub Actions / Build and test

0..-1 has a default step of -1, please write 0..-1//-1 instead
setup(:verify_on_exit!)