Dev #52
Merged
Dev #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Command.Execute` call within the button click event handler was redundant since the command is already executed elsewhere. This change improves code readability and prevents potential double execution of the command.
Added a new IsDiskFull resource string in multiple languages to display an error message when the disk is full. Updated the SystemService and OverviewPageViewModel to catch IOException and check for disk full errors using the new IsDiskFull method in SystemService.
Introduce a new error message "GameProfileError" in resource files. Implement logic to capture and display this error when initializing game profiles, ensuring errors are properly logged and displayed to the user.
Commented-out code added as a placeholder for future Sentry logging implementation. This will facilitate capturing Java log4j-related exceptions once the actual logging code is integrated.
This new constant will be used to provide an error message for issues related to game profiles. It ensures that error handling for game profiles is more robust and maintainable.
…j to address the NETSDK1206 warning. Also adding RuntimeIdentifiers for faster builds.
Solving the error for folders that have UTF-8 characters or spaces in the name and fix Warnings
Re-add the GameProfileError constant to ensure error handling for game profiles is defined. This change corrects its previous removal and maintains consistency in the dictionary.
Add a Console.WriteLine statement to log error data from the process. This helps in debugging by providing immediate visibility of any error output that is not filtered by the existing conditions.
Importing the SplashScreen view allows the application to display a splash screen during launch. Additionally, updating the OnFrameworkInitializationCompleted method to be asynchronous supports potential future asynchronous operations.
Imported necessary namespaces and updated OnFrameworkInitializationCompleted to be asynchronous to support splash screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.