Attempt to fix SCAP CI #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the git history I see the following three events: - I had guarded InnerXml support - available in case we knew for sure InnerXml is needed - then we went with InnerXml being parsed all the time - then we saw some problems and disable InnerXml together Not trying to be impolite to outside contributors, but boy haven't the original design been better than the current end state? This reverts commit ac7b5f0 and 032abf4 Addressing: + go vet ./... Error: pkg/scap/models/cpe_language/models.go:84:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:96:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:110:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:126:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:134:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:144:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:158:2: struct field innerXml has xml tag but is not exported Error: pkg/scap/models/cpe_language/models.go:167:2: struct field innerXml has xml tag but is not exported ... and thousand other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.