Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect REAL128 in Assert_Complex #362

Closed
wants to merge 5 commits into from
Closed

Protect REAL128 in Assert_Complex #362

wants to merge 5 commits into from

Conversation

havogt
Copy link

@havogt havogt commented Jun 15, 2022

Enables compilation with nvhpc (tested with 22.3).

Maybe related to discussion in #337.

@havogt havogt mentioned this pull request Jun 15, 2022
Closed
@havogt
Copy link
Author

havogt commented Jun 15, 2022

After debugging the segfault described in #363, I noticed that this fix seems to be needed in some environments (e.g. my laptop with openSUSE tumbleweed), but not in all environments (e.g. not in the ubuntu based docker container that is mentioned in #363).

tclune
tclune approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the conditionals in the

@havogt
Copy link
Author

havogt commented Jun 16, 2022

Note that Assert_Real has these #ifdefs

pFUnit/src/funit/asserts/Assert_Real.tmpl

Line 129 in 26ac761

#ifdef _ISO_REAL16
. I just copied from there and it fixed my problem. (In the meantime I upgraded my system and cannot reproduce the failure anymore.)

@tclune
Copy link
Member

tclune commented Jun 17, 2022

Yes - the #ifdefs there are also unnecessary. Probably not worth fixing, but I'll try to remember the next time I make a change.

@tclune tclune closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @tclune