Remove explicit CMake in CI #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft as the GitHub images with 3.25.1 are only in pre-release. Oops. |
tclune
approved these changes
Jan 2, 2023
|
I think CMake 3.25.1 is now on the images. I'm re-running the CI and if it works, I'll undraft this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, GitHub Actions images now have CMake 3.25.1. From my reading of the git log of CMake, this should have the fix for pFUnit's cmake issue seen earlier (see #399).
This will be a good test!
NOTE: The changelog entry for this is weird as it talks about the changes from @scivision in #403, but until #401 gets in, the changelog isn't enforced.