ShlomiShitrit/issue15 - Add Description #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShlomiShitrit
changed the title
nadavWeisler
reviewed
Oct 9, 2024
src/app/components/Header/Header.tsx
Outdated
|
|
||
| const rows: generalObject<strOrNum>[] = []; | ||
|
|
||
| [0, 1, 2, 3, 4].forEach((index) => { |
There was a problem hiding this comment.
Something is not elegant here? Why not iterate the column instead of [0...5]?
| {text} | ||
| </Typography> | ||
| <Box component="div" sx={styles.buttonContainer}> | ||
| <Button |
There was a problem hiding this comment.
Consider saving components like that in another element; if you have several buttons you use and set all the parameters every time, it is a way for the typo that can harm consistency in the UI. Still, If you create and use a custom button with all the attributes, you fix it. Don't do that now, but it opens an issue with low priority for generalise ui components like the button.
src/app/components/Header/Header.tsx
Outdated
| sx={styles.dataButton} | ||
| onClick={() => setOpenData(true)} | ||
| > | ||
| Display Data Sample |
src/app/components/Header/Header.tsx
Outdated
| sx={styles.attributeButton} | ||
| onClick={() => setOpenAttribute(true)} | ||
| > | ||
| Display Attributes |
src/app/components/Table/Table.tsx
Outdated
| <TableRow | ||
| key={index} | ||
| sx={{ | ||
| "&:last-child td, &:last-child th": { |
There was a problem hiding this comment.
why not in style.ts file?
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success26 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 7728a5b |
nadavWeisler
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Images: