feat: simplifies the abstraction for Events API messages #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the
Event
abstraction by removing theEventCallbackType
andEventType
definitions. Through some better utilization in serde we can simplify these type definitions and avoid an unnecessary abstraction that doesn't add much value.My goal here was to simplify the existing API - as it seemed like there were easier ways to accomplish what the
EventType
andEventCallbackType
structs were trying to accomplish. As an added bonus this also reduces the amount of boilerplate you need to have to unwrap the contents of the Events API message.Previously to access the contents of the
Event
one had to have nestedmatch
statementsThis PR gets rid of this intermediate abstraction and allows you to match directly on the event while preserving the pattern matching in the previous version (matching on the
EventCallback::AppHomeOpened
type)