[#883] Incomplete Bids #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd-viget
requested review from
joshuapease,
clatwell,
nathan-schmidt-viget and
jaspercroome
|
Let's hold off on merging this in until we get #889 up + released to production for testing. I just wanna be sure we check this thoroughly on Staging before it hits prod. |
|
With #889 up on Production, I think we can now continue with this work. |
bd-viget
force-pushed
the
bd/883-incomplete-bids
branch
from
baa11ba to
0f31ebf
Compare
nathan-schmidt-viget
approved these changes
Apr 17, 2024
bd-viget
force-pushed
the
bd/883-incomplete-bids
branch
from
0f31ebf to
745dfae
Compare
|
@jaspercroome This should be ready for testing. |
jaspercroome
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR mainly deletes orders that are placed after an Auction has ended, or when another bid has already been placed.
There are a few other updates in this PR:
nocache_headers()to Bid and Reward custom URL endpoints that add to cartIssues
Testing Instructions