Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[897] - add an 'ending soon' email for watchers and bidders #898

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

jaspercroome
Copy link
Contributor

Summary

From @bd-viget 's expert guidance, attempting to add an email that goes to watchers and bidders of a given auction when that auction is between 3 and 4 hrs from closing.

  • I hard-coded the 3-4 because I was unsure how to access an auction's bid extension window data.
  • Ideally, the email would go out once, when an auction is between [bid_extension_window/3] and [bid_extension_window/3] + 1hr
  • for now, all our auctions have 12 hour extension windows. so the static values are "accurate". happy to follow-up in another PR with the dynamic values if that's too much of a stretch

Issues

#897

Testing Instructions

Need to deploy to staging to test emails, dev email license is derelict.

@jaspercroome jaspercroome requested a review from bd-viget April 16, 2024 12:54
@jaspercroome jaspercroome merged commit 237427d into main Apr 16, 2024
1 check passed
@jaspercroome jaspercroome deleted the jc/enhance-emails branch April 16, 2024 19:41
@jaspercroome
Copy link
Contributor Author

@bd-viget I merged this in so that I can move forward with testing. Would still appreciate your eyes on it when you get a chance 🙇‍♂️ 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant