Fix schema, make it stricter, add tests #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The RWS JSON was successfully validated! |
arichiv
approved these changes
Dec 13, 2024
| ] | ||
| } | ||
| rws_check = RwsCheck(rws_sites=json_dict, etlds=None, icanns=set(["ca"])) | ||
| with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
for all the tests, it would be nice to test something more specific so you know it's the error you expected and not just any error. It doesn't have to be in this PR (and maybe shouldn't be), but it would be nice to have specificity in the message of the exception or the exception class
There was a problem hiding this comment.
Yeah, agreed. I'm not sure if we get fine-grained detail from the schema validator, but it'd be a good thing to look into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the feedback in #506. Namely: