Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds controls attribute to final controlsList media sample #619

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

bgradin
Copy link

@bgradin bgradin commented Nov 20, 2018

The final sample on the controlsList samples page is missing the controls attribute, so you can't see the controls.

The final sample on the controlsList samples page is missing the `controls` attribute, so you can't see the controls.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@bgradin
Copy link
Author

bgradin commented Nov 20, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@beaufortfrancois
Copy link
Member

The last one is specifically about not showing controls. The previous one has controls though.

image

@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 7 times, most recently from c198a70 to 03c4155 Compare November 26, 2022 06:50
@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 5 times, most recently from 1de1b35 to c4f3954 Compare October 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants