Tentacles v4.1.2

Fix the error when check firestore in bash script
GoogleCloudPlatform · Nov 9, 2023 · 6bbcf8c · 6bbcf8c
1 parent ac832d8
commit 6bbcf8c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/marketing-analytics/activation/common-libs/nodejs-common/bin/install_functions.sh b/marketing-analytics/activation/common-libs/nodejs-common/bin/install_functions.sh
@@ -1933,7 +1933,8 @@ check_firestore_existence() {
   local firestore mode appRegion
   mode="${1}"
   appRegion="${2}"
-  firestore=$(gcloud firestore databases list --format="csv[no-heading](databases.type)")
+  firestore=$(gcloud firestore databases list \
+--filter="name:(default)" --format="csv[no-heading](type)")
   if [[ -z "${firestore}" ]]; then
     printf '%s\n' "Firestore is not ready. Creating a new Firestore database\
 is an irreversible operation, so read carefully before continue:"

diff --git a/marketing-analytics/activation/common-libs/nodejs-common/package.json b/marketing-analytics/activation/common-libs/nodejs-common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@google-cloud/nodejs-common",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "description": "A NodeJs common library for solutions based on Cloud Functions",
   "author": "Google Inc.",
   "license": "Apache-2.0",

diff --git a/marketing-analytics/activation/gmp-googleads-connector/package.json b/marketing-analytics/activation/gmp-googleads-connector/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@google-cloud/gmp-googleads-connector",
-  "version": "4.1.1",
+  "version": "4.1.2",
   "description": "GMP & Google Ads connector based on Cloud Functions",
   "author": "Google Inc.",
   "license": "Apache-2.0",
@@ -20,7 +20,7 @@
   "homepage": "https://github.com/GoogleCloudPlatform/cloud-for-marketing/blob/master/marketing-analytics/activation/gmp-googleads-connector/README.md",
   "main": "index.js",
   "dependencies": {
-    "@google-cloud/nodejs-common": "1.9.0",
+    "@google-cloud/nodejs-common": "1.9.1",
     "@google-cloud/storage": "^7.0.1",
     "nanoid": "^3.3.4",
     "ssh2-sftp-client": "^8.0.0"

diff --git a/marketing-analytics/activation/gmp-googleads-connector/src/tentacles.js b/marketing-analytics/activation/gmp-googleads-connector/src/tentacles.js
@@ -216,7 +216,7 @@ class Tentacles {
 
   /**
    * Based on the size of bytes in one record/line and the qps of config, gets
-   * the best split size of a task.
+   * the best split size (MB) of a task.
    * @param {StorageFile} storageFile
    * @param {Object} taskBaseInfo
    * @return {number}