-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatically reset DNS-configured connections on DNS change. Part of #2043 #2056
Draft
hessjcg
wants to merge
1
commit into
main
Choose a base branch
from
gh-2043-update-on-dns-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
2 times, most recently
from
August 16, 2024 15:26
cf7698a
to
7475041
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
August 16, 2024 15:26
cf1d9c6
to
5513e3a
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
August 30, 2024 17:54
7475041
to
8ceb527
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
August 30, 2024 17:54
5513e3a
to
190bf6c
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
September 27, 2024 21:22
190bf6c
to
1597e44
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
September 27, 2024 21:22
8ceb527
to
cf79bec
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
October 1, 2024 16:07
1597e44
to
eabb057
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 10, 2025 18:20
170f88f
to
4ad47df
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 10, 2025 18:20
eabb057
to
7b335a0
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 13, 2025 18:47
4ad47df
to
e885216
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
2 times, most recently
from
January 13, 2025 18:51
fd4e87a
to
f509ea1
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 13, 2025 18:51
e885216
to
93145cf
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 14, 2025 19:30
f509ea1
to
a6d1e48
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
2 times, most recently
from
January 14, 2025 22:16
782f666
to
89c1f22
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 14, 2025 22:26
a6d1e48
to
f38d678
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
2 times, most recently
from
January 14, 2025 22:49
a10e852
to
9b2fe06
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 14, 2025 22:49
f38d678
to
13bc70f
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
2 times, most recently
from
January 16, 2025 21:18
1930978
to
de8f2dd
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
2 times, most recently
from
January 17, 2025 18:44
da9f3ba
to
ad4b8e3
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 17, 2025 18:44
de8f2dd
to
2b909fd
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 17, 2025 18:59
ad4b8e3
to
f9b1477
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 17, 2025 19:41
475ac57
to
ca711d8
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 17, 2025 19:41
f9b1477
to
e3885bc
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 23, 2025 16:47
ca711d8
to
3cd89b1
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
3 times, most recently
from
January 23, 2025 18:54
e0bbb24
to
914dfdb
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 23, 2025 20:56
e3885bc
to
fc24478
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
2 times, most recently
from
January 23, 2025 21:20
78f1345
to
06dec39
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 23, 2025 21:20
fc24478
to
ad609e0
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
January 23, 2025 21:36
06dec39
to
a993bcd
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
2 times, most recently
from
January 23, 2025 22:05
1f6cc68
to
d3e9d55
Compare
hessjcg
force-pushed
the
gh-2043-update-on-dns-change
branch
from
January 23, 2025 22:38
d3e9d55
to
7d3a702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poll for changes to the DNS entry every 30 seconds and update the connector to connect to the new
instance when the value of the DNS TXT record changes. Close all existing sockets connected to the old
instance.
See also: GoogleCloudPlatform/cloud-sql-go-connector#844
Fixes #2043