chore: Add domain name to the connector config. #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
hessjcg
force-pushed
the
gh-2043-config-domain-name
branch
3 times, most recently
from
cf8fc9d to
0bd57d4
Compare
pandirigoog
reviewed
Jan 16, 2025
| this.connectionName = connectionName; | ||
| this.domainName = domainName; |
There was a problem hiding this comment.
Do we want to validate it with some DOMAIN_NAME matcher ? generic DNS name or something ?
There was a problem hiding this comment.
Done. I added a Regex to validate the domain name.
pandirigoog
reviewed
Jan 16, 2025
| @@ -154,6 +157,37 @@ ConnectionInfoCache getConnection(ConnectionConfig config) { | |||
| return instance; | |||
| } | |||
|
|
|||
| private ConnectionConfig resolveConnectionName(ConnectionConfig config) { | |||
There was a problem hiding this comment.
I know its private method (so method documentation is optional) but I think this method is important enough that it requires some explanation. Like cloudSqlInstance is prioritized over domainName when both are set etc.
| @@ -131,6 +131,50 @@ public void create_successfulPrivateConnection() throws IOException, Interrupted | |||
| assertThat(readLine(socket)).isEqualTo(SERVER_MESSAGE); | |||
| } | |||
|
|
|||
| @Test | |||
| public void create_successfulPublicConnectionWithDomainName() | |||
There was a problem hiding this comment.
Can we have a test for both domainName and cloudSqlInstance set?
hessjcg
force-pushed
the
gh-2043-config-domain-name
branch
3 times, most recently
from
2685a44 to
14f7483
Compare
pandirigoog
approved these changes
Jan 22, 2025
jackwotherspoon
approved these changes
Jan 23, 2025
pandirigoog
approved these changes
Jan 23, 2025
See #2043 for the whole feature definition.
hessjcg
force-pushed
the
gh-2043-config-domain-name
branch
from
14f7483 to
9536668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DomainName to connection config, and an InstanceNameResolver function. This will allow the connector
to be configured using a domain name referencing the instead of the instance name.
This is part of the implementation of #2043.
See #2043 for the whole feature definition.