Fix flaky list large dir test #2855
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2855 +/- ##
==========================================
+ Coverage 76.11% 76.17% +0.06%
==========================================
Files 118 118
Lines 16557 16637 +80
==========================================
+ Hits 12603 12674 +71
- Misses 3423 3430 +7
- Partials 531 533 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| fi | ||
|
|
||
| PATH=$1 | ||
| # Run the gcloud command and suppress known errors |
There was a problem hiding this comment.
Why aren't we use static bucket? That will remove the problem due to creation and deletion.
There was a problem hiding this comment.
This is a temporary workaround, a quick fix, until we implement a more permanent solution. Using a static bucket would require significant changes, potentially impacting our CD pipeline. So, for now, I've implemented this quick fix to prevent further issues while we work on a more comprehensive solution.
kislaykishore
requested review from
a team,
BrennaEpp,
gargnitingoogle and
tritone
and removed request for
a team,
BrennaEpp and
gargnitingoogle
|
|
||
| DIR_PATH=$1 | ||
| # Run the gcloud command and suppress known errors | ||
| gcloud storage rm -r gs://${DIR_PATH}/** 2>&1 | grep -v -E "The following URLs matched no objects|404" |
There was a problem hiding this comment.
won't gcloud command still fail in this case? we just won't see 404 errors in the output?
Description
Implementing measures to avoid 404 errors when removing data after testing. Even if a file or folder cannot be deleted, it won't cause issues because:
This is a temporary workaround, a quick fix, until we implement a more permanent solution. Using a static bucket would require significant changes, potentially impacting our CD pipeline. So, for now, I've implemented this quick fix to prevent further issues while we work on a more comprehensive solution.
Link to the issue in case of a bug fix.
b/380007938
Testing details