mockgcp: add support for storage bucket list #3469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Jan 10, 2025
justinsb
commented
- tests: add mock tests that use gcloud
- mockgcp: add support for storage bucket list
This can enable testing of mockgcp before we have the full controller etc.
This isn't needed by KCC (today), but is a good test for our direct tests.
yuwenma
reviewed
Jan 12, 2025
| services := mockgcp.ListServices() | ||
|
|
||
| // We need a hard-coded list, because we don't always mockgcp available | ||
| services := []string{ |
There was a problem hiding this comment.
Since we have more and more hard-coded lists in the MockGCP, we may want to start moving them to its own file mockgcp/const dir or at least to the top of this file, otherwise the maintenance overhead will continue grow dramatically.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.