This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Adding tests for validating remove-clusters command flags #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@perotinus Can you please review this one? |
nikhiljindal
force-pushed
the
removeClustersTest
branch
from
1a24c68 to
23bd70f
Compare
perotinus
reviewed
Mar 27, 2018
| "github.com/GoogleCloudPlatform/k8s-multicluster-ingress/app/kubemci/pkg/kubeutils" | ||
| ) | ||
|
|
||
| // Test to verify validate. |
There was a problem hiding this comment.
nit: Go style is to have the function name as the first word in the comment.
TestValidateRemoveClusterArgs tests all flags...
| func TestValidateRemoveClustersArgs(t *testing.T) { | ||
| // validateRemoveClustersArgs should return an error with empty options. | ||
| options := removeClustersOptions{} | ||
| if err := validateRemoveClustersArgs(&options, []string{}); err == nil { |
There was a problem hiding this comment.
This looks like it could be a table-style test. But I suppose that could come in a follow-up PR.
|
/lgtm unless you want to modify to table-based tests. |
nikhiljindal
force-pushed
the
removeClustersTest
branch
from
23bd70f to
05a3b5a
Compare
|
Thanks @perotinus |
This was referenced Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #146.
Adding tests to verify flags are validated as expected. This is similar to tests for other commands.
cc @csbell @G-Harmon @perotinus