Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump distroless-iptables to v0.3.1 and Go to 1.21 #223

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

jingyuanliang
Copy link
Member

No description provided.

@jingyuanliang
Copy link
Member Author

/assign @MrHohn

@jingyuanliang jingyuanliang changed the title Bump distroless-iptables to v0.3.1 Bump distroless-iptables to v0.3.1 and Go to 1.21 Sep 7, 2023
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Sep 7, 2023
Also bump bash-static to the version from Debian 12 (Bookworm), since
distroless-iptables v0.3.1 is now based on Debian 12, and bash-static
from Debian 11 crashes with SIGSEGV there.
@@ -63,7 +63,7 @@ RUN /alpine-extractor.sh musl openssl-dev openssl-libs-static linux-headers

## The bash container fetches bash-static (to be used as bash) from Debian repo.

FROM debian:11.4 AS bash
FROM debian:bookworm-slim AS bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had some hiccups with this change, have you verified this is ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a cluster and confirmed it working.

Copy link
Collaborator

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 7, 2023
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MrHohn,jingyuanliang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit acc553f into master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants