Only attach instrumentation scope/service labels when non-empty #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
reviewed
Mar 14, 2023
| droppedMessageEvents: int(span.DroppedEventsCount()), | ||
| droppedLinks: int(span.DroppedLinksCount()), | ||
| resource: r, | ||
| instrumentationLibrary: instrumentationScopeLabels(is), |
There was a problem hiding this comment.
Consider renaming this field to instrumentationScope in a separate PR.
aabmass
reviewed
Mar 14, 2023
...er/collector/integrationtest/testdata/fixtures/logs/logs_apache_access_batches_expected.json
Show resolved
Hide resolved
damemi
changed the title
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 63.37% 63.36% -0.02%
==========================================
Files 38 38
Lines 4409 4446 +37
==========================================
+ Hits 2794 2817 +23
- Misses 1491 1504 +13
- Partials 124 125 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377
This updates the metrics and traces exporters (for SDK and collector) to only attach instrumentation library labels to GCP if those labels are non-empty as otel attributes. This applies even if the option to include instrumentation library labels is set to
true.This also updates the metrics, traces, and logs exporters to do the same for service labels (also even if the service labels option is set to true).
This PR also makes updates to tests to prevent 2 tests overwriting each others' fixtures.
tl;dr I spent way too much time digging through Go internals, proto marshalling, and gzip libraries before I realized that the gzip test added in #576 overwrote another test's fixture. This prevented me from reproducing the bug's behavior. Now
make fixtureswill fail if it sees 2 tests writing to the same output fixture.