Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm workspaces instead of lerna bootstrap #557

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Jun 21, 2023

Fixes #499

This will unblock moving to lerna 7 and makes development generally faster and less error prone. I did have to wrap the lint and fix commands with a small script because of google/gts#490.

@aabmass aabmass requested a review from a team as a code owner June 21, 2023 03:49
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #557 (ec1c8a8) into main (f1d15c8) will increase coverage by 0.18%.
The diff coverage is n/a.

❗ Current head ec1c8a8 differs from pull request most recent head 8739a4e. Consider uploading reports for the commit 8739a4e to get more accurate results

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   95.86%   96.05%   +0.18%     
==========================================
  Files          17       18       +1     
  Lines         629      659      +30     
  Branches      108      119      +11     
==========================================
+ Hits          603      633      +30     
  Misses         26       26              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass force-pushed the npmworkspaces branch 6 times, most recently from 63a1b2c to de94df1 Compare June 21, 2023 13:56
@aabmass aabmass merged commit 90d3ab0 into GoogleCloudPlatform:main Jun 22, 2023
@aabmass aabmass deleted the npmworkspaces branch June 22, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use npm workspaces with lerna instead of lerna bootstrap
2 participants