Clean up configuration generation for fluentbit configs. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinmit
force-pushed
the
igorpeshansky-config-cleanup-generation-otel
branch
2 times, most recently
from
b24888f to
1880902
Compare
quentinmit
force-pushed
the
igorpeshansky-config-cleanup-generation-fluentbit
branch
from
84471f1 to
32de84c
Compare
Base automatically changed from
igorpeshansky-config-cleanup-generation-otel
to
master
August 18, 2021 03:46
igorpeshansky
force-pushed
the
igorpeshansky-config-cleanup-generation-fluentbit
branch
from
37357c7 to
ee44b12
Compare
igorpeshansky
commented
Aug 20, 2021
There was a problem hiding this comment.
This is now ready for review. @quentinmit, the last commit will have minor conflicts with your branch. It does introduce useful functionality, IMO, but we can discuss reverting it as well.
qingling128
reviewed
Aug 20, 2021
quentinmit
approved these changes
Aug 23, 2021
… replicates what we have in the ops agent config.
… fluentbit.Input interface. Unify fluentbit's filters under the fluentbit.Filter interface, and fluentbit's parsers under the fluentbit.Parser interface. Wrap fluentbit's Stackdriver into the fluentbit.Output interface. Use the fluentbit.Input, fluentbit.Filter, fluentbit.Output, and fluentbit.Parser interfaces instead of the individual structs. Template expansion whitespace control is hell, so there are no longer two blank lines at the end of the config. No other changes to the generated configs.
igorpeshansky
force-pushed
the
igorpeshansky-config-cleanup-generation-fluentbit
branch
from
ee44b12 to
ec5c73f
Compare
igorpeshansky
deleted the
igorpeshansky-config-cleanup-generation-fluentbit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #141.