Pluginify Ops Agent #1840
Draft
Pluginify Ops Agent #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuechunHou
force-pushed
the
xuechun-go-yaml
branch
from
e555318 to
34cb619
Compare
XuechunHou
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
XuechunHou
force-pushed
the
xuechun-go-yaml
branch
2 times, most recently
from
56e169b to
92d4e0a
Compare
XuechunHou
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
quentinmit
reviewed
Dec 2, 2024
| @@ -4435,7 +4435,7 @@ func getRecentServiceOutputForImage(imageSpec string) string { | |||
| }, ";") | |||
| return cmd | |||
| } | |||
| return "sudo systemctl status google-cloud-ops-agent" | |||
| return "sudo cat /var/log/google-cloud-ops-agent/health-checks.log && sudo systemctl status google-cloud-ops-agent" | |||
There was a problem hiding this comment.
Why are we moving health checks to their own log file? systemctl status is where users expect to see error messages.
quentinmit
reviewed
Dec 2, 2024
| @@ -27,4 +27,4 @@ ExecStartPre=@PREFIX@/libexec/google_cloud_ops_agent_engine -service=fluentbit - | |||
| ExecStart=@PREFIX@/libexec/google_cloud_ops_agent_wrapper -config_path @SYSCONFDIR@/google-cloud-ops-agent/config.yaml -log_path ${LOGS_DIRECTORY}/subagents/logging-module.log @PREFIX@/subagents/fluent-bit/bin/fluent-bit --config ${RUNTIME_DIRECTORY}/fluent_bit_main.conf --parser ${RUNTIME_DIRECTORY}/fluent_bit_parser.conf --storage_path ${STATE_DIRECTORY}/buffers | |||
| Restart=always | |||
| # For debugging: | |||
| RuntimeDirectoryPreserve=yes | |||
| RuntimeDirectoryPreserve=yes | |||
There was a problem hiding this comment.
You have whitespace changes in these service files (it looks like you're removing the trailing newline).
|
Is there a design doc you can link me to for these changes? |
XuechunHou
force-pushed
the
xuechun-go-yaml
branch
from
90a9278 to
6aa4435
Compare
…Please run `go run ./dockerfiles`"
…-agent/libexec/google_cloud_ops_agent_uap_plugin"
status`. Updated the test to check `health-checks.log` to confirm health check statuses.
off commands that restart. Also added designated signal handlers for each go routines; the signal handler responds to SIGTERM and cancels the context on trigger.
now causes Start() to return an RPC error. Context will be cancelled on config generation failures, resulting in GetStatus() returning an inactive status.
start up more than 3 times, the plugin will stop restarting the command.
XuechunHou
force-pushed
the
xuechun-go-yaml
branch
from
b8ee43e to
ff2299a
Compare
XuechunHou
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
kokoro:force-run
output then the systemd service is also not present. Added the case to the conflicting installation check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue
How has this been tested?
Checklist: