Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement to uninstall standalone agents #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ekund
Copy link
Contributor

@ekund ekund commented May 6, 2021

In order to ease migration, remove the uninstallation of the standalone agents so that a customer can install the opsagent to run only a monitoring agent, while using that standalone logging agent, or vice versa.

This PR removes the uninstall for Linux and Windows.

@ekund ekund requested review from quentinmit and qingling128 May 6, 2021 19:15
@qingling128
Copy link
Contributor

One concern that drove the original implementation was to prevent users from:

  • getting double billed for logging
  • getting requests rejected due to conflicts for metrics.

This might happen if:

  • Users have a standalone Fluentd agent and an Ops agent that collects system logs as well
    or
  • Users have a standalone Collectd agent and an Ops agent that collects host metrics as well

Any chance we could check whether the Ops agent config has enabled system log / host metrics, and use that to decide whether to error out or let it through? For Linux, this might require implementing something similar to the Windows side instead of relying on package conflicts settings. How much effort is that?

@qingling128
Copy link
Contributor

@davidbtucker for visibility

@ekund
Copy link
Contributor Author

ekund commented May 6, 2021

I am concerned about implementing that, since we have the default config baked in to the package. There is no mechanism right now to install the config with the yaml file edited to remove the config, so I am not clear on how we would even implement that.

@qingling128
Copy link
Contributor

One alternative is to give a warning instead of a hard error. Let's discuss a bit more in tomorrow's meeting.

@njculver
Copy link

Are there any updates on this? With the capability gap that exists between ops agent and the legacy logging agent, it would be very helpful to be able to run the ops agent for monitoring side by side with the legacy logging agent.

@aabrahamyan-ripple
Copy link

any updates?

@qingling128
Copy link
Contributor

Hi, this effort is now being reconsidered in prioritization discussions. Previously it was de-prioritized for competing priorities.

BTW, if you are interested in providing some insights of the remaining gaps between the legacy agent and Ops Agent that are affecting your workloads, it would be very helpful for our prioritization.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants