Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the vet linter errors for non-constant format strings in logging calls. #786

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

zoltak-g
Copy link
Contributor

@zoltak-g zoltak-g commented Feb 3, 2025

No description provided.

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member

@burov burov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a good start, we still might want to change it to specific formats if it possible

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: burov, zoltak-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zoltak-g zoltak-g marked this pull request as ready for review February 3, 2025 16:05
@google-oss-prow google-oss-prow bot merged commit ca7a31c into GoogleCloudPlatform:master Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants