Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RebootCount to PostPatchRebootCount and only increment it for post-patch reboots. #787

Closed
wants to merge 2 commits into from

Conversation

zoltak-g
Copy link
Contributor

@zoltak-g zoltak-g commented Feb 3, 2025

RebootCount was used only for forcing post-patch reboots via RebootConfig = always, but incremented for every reboot. As a result, the forced post-patch reboot was skipped if pre-patch reboot was required.

Closes: #755

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zoltak-g

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zoltak-g zoltak-g closed this Feb 3, 2025
@zoltak-g zoltak-g deleted the vet-fixes branch February 3, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"RebootConfig = always" logic in pre and post-patch seems wrong
1 participant