feat: Cater for ExtractEpochSeconds overflowing integer #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mn-postgresql-epoch-seconds-exception
sundar-mudupalli-work
previously requested changes
Jan 16, 2025
There was a problem hiding this comment.
Would have loved to have some test data with the max MySQL Timestamp - i.e. 3001-01-19 03:14:07.999999 - one way I suggest is to put it in its own row and filter it out using --fliter for those engines that it does not make sense I am wondering - might we have an issue like 1396, where the combiner has a fit.
Thank you.
Sundar Mudupalli
There was a problem hiding this comment.
Thanks, you were absolutely right that MySQL falls into the same issue as other engines for min/max. I made a mistake when excluding the low/high columns, the limitation only applies to SUM.
I've rectified this mistake. Good spot.
|
/gcbrun |
renzokuken
approved these changes
Jan 22, 2025
nj1973
dismissed
sundar-mudupalli-work’s stale review
Mike reviewed during vacation
|
/gcbrun |
nehanene15
approved these changes
Jan 22, 2025
nj1973
deleted the
1390-validate-column-postgresql-epoch-seconds-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
ExtractEpochSecondsfor PostgreSQL, Teradata and SQL Server.It also adds tests for large ranges of values for
ExtractEpochSecondsto have to deal with.