Add helm chart #273

bhavanapalle2023 · 2023-07-06T14:23:15Z

No description provided.

amitmodak · 2023-07-07T04:42:05Z

README.md

-kubectl apply -f deploy/provider-gcp-plugin.yaml
-# if you want to use helm
-# helm upgrade --install secrets-store-csi-driver-provider-gcp charts/secrets-store-csi-driver-provider-gcp
+$ export PROJECT_ID=<your gcp project>


We should not merge this change in instructions unless the package is indeed available in the public repo.

done, back to original ReadMe

amitmodak · 2023-07-07T04:43:25Z

scripts/cloudbuild-dev.yaml

@@ -15,10 +15,30 @@
 # Usage: from the root directory run:
 #
 # $ gcloud builds submit --config scripts/cloudbuild-dev.yaml
-timeout: 1200s
+timeout: 3600s  #increasing timeout else build crashes


Nit: no need for the comment

Removed the comment

amitmodak · 2023-07-07T04:43:53Z

scripts/cloudbuild-dev.yaml

@@ -27,6 +47,7 @@ steps:
         '--build-arg',
         'VERSION=$TAG_NAME',
         '-t',
-         'gcr.io/$PROJECT_ID/secrets-store-csi-driver-provider-gcp:$TAG_NAME',
+         'asia-east1-docker.pkg.dev/$PROJECT_ID/secrets-store-csi-driver-provider-gcp/provider-image:$TAG_NAME',


Why is this change required?

As Container Registry is Depreciating, Made helm image repo, helm chart repo and provider image in the Artifact registry

amitmodak · 2023-07-07T04:48:27Z

charts/secrets-store-csi-driver-provider-gcp/templates/daemonset.yaml

@@ -23,7 +23,7 @@ spec:
      serviceAccountName: {{ include "secrets-store-csi-driver-provider-gcp.serviceAccountName" . }}
      containers:
        - name: provider
-          image: "{{ .Values.image.repository }}@{{ .Values.image.hash }}"
+          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"


Using a hash is considered more secure and we should continue to reference by hash.

amitmodak · 2023-07-07T04:49:59Z

charts/secrets-store-csi-driver-provider-gcp/Chart.yaml

@@ -4,3 +4,7 @@ description: A Helm chart to install Google Secret Manager Provider for Secret S
 type: application
 version: 0.1.0


I think its okay to keep the version same as appVersion

amitmodak · 2023-07-07T04:50:41Z

charts/secrets-store-csi-driver-provider-gcp/values.yaml

@@ -6,8 +6,8 @@ serviceAccount:

 image:
  repository: us-docker.pkg.dev/secretmanager-csi/secrets-store-csi-driver-provider-gcp/plugin
+  tag: v1.2.0


Same as above, please continue to use hash references.

amitmodak · 2023-07-07T04:52:58Z

scripts/cloudbuild-dev.yaml

+         '--build-arg',
+         'VERSION=$TAG_NAME',
+         '-t',
+         'asia-east1-docker.pkg.dev/$PROJECT_ID/secrets-store-csi-driver-provider-gcp/helm-image:$TAG_NAME',


Why is this change required?

To create helm docker image, As there are no publicaly available helm image. Used Artifact Registry for Repo.

amitmodak · 2023-07-07T04:53:56Z

scripts/cloudbuild-dev.yaml

+         '--push',
+         './helm']
+- name: 'asia-east1-docker.pkg.dev/$PROJECT_ID/secrets-store-csi-driver-provider-gcp/helm-image:$TAG_NAME'
+  args: ['dependency', 'update', './charts/secrets-store-csi-driver-provider-gcp']


Nit: it might be good to put each arg on a new line.

underscoreanuj · 2023-07-17T04:49:36Z

scripts/build.sh

@@ -19,6 +19,11 @@ set -o pipefail # Check the exit code of *all* commands in a pipeline
 set -o nounset  # Error if accessing an unbound variable
 set -x          # Print each command as it is run

+set +e
+# Creating a new repository secrets-store-csi-driver-provider-gcp
+gcloud artifacts repositories create  secrets-store-csi-driver-provider-gcp --repository-format=docker    --location=asia-east1 


nit: inconsistent spacing between keywords, is that intended (2 files)?

Made the space consistent between the keywords in both the files

underscoreanuj · 2023-07-17T04:55:44Z

test/e2e/mount_test.go

+		os.Exit(1)
+	}
+	// Create the helm registry login command
+	helmCmd := exec.Command("helm", "registry", "login", "-u", "oauth2accesstoken", "--password-stdin", "https://asia-east1-docker.pkg.dev")


Can you confirm if the usage of asia-east1 across this commit is just a choice of region & it can be substituted with a different supported region if required?
If yes, can this be made a constant which is referred everywhere?

+1, we should use gcr.io instead of regional endpoints wherever possible.

underscoreanuj

LGTM!
left a few comments, PTAL :)

amitmodak · 2023-07-24T15:39:50Z

scripts/build.sh

@@ -19,6 +19,11 @@ set -o pipefail # Check the exit code of *all* commands in a pipeline
 set -o nounset  # Error if accessing an unbound variable
 set -x          # Print each command as it is run

+set +e
+# Creating a new repository secrets-store-csi-driver-provider-gcp
+gcloud artifacts repositories create secrets-store-csi-driver-provider-gcp --repository-format=docker --location=asia-east1 


Why is location asia-east1?

amitmodak · 2023-07-24T15:40:45Z

test/e2e/mount_test.go

+		os.Exit(1)
+	}
+	// Create the helm registry login command
+	helmCmd := exec.Command("helm", "registry", "login", "-u", "oauth2accesstoken", "--password-stdin", "https://asia-east1-docker.pkg.dev")


+1, we should use gcr.io instead of regional endpoints wherever possible.

amitmodak · 2023-07-24T15:41:27Z

test/e2e/templates/provider-gcp-plugin-wif.yaml.tmpl

@@ -86,7 +86,7 @@ spec:
      serviceAccountName: secrets-store-csi-driver-provider-gcp
      containers:
        - name: provider
-          image: gcr.io/$PROJECT_ID/secrets-store-csi-driver-provider-gcp:$GCP_PROVIDER_SHA
+          image: asia-east1-dev.pkg/$PROJECT_ID/secrets-store-csi-driver-provider-gcp/provider-image:$GCP_PROVIDER_SHA


Why has the name of the image changed?

bhavanapalle2023 added 8 commits July 6, 2023 14:14

Update cloudbuild-dev.yaml

3799449

Update provider-gcp-plugin-wif.yaml.tmpl

f8deca8

Update provider-gcp-plugin.yaml.tmpl

c4933dc

Update mount_test.go

43ccd5a

Update runner.sh

fda1008

Update Chart.yaml

f3595d3

Update values.yaml

1827c55

Update daemonset.yaml

29f62d1

bhavanapalle2023 requested review from tam7t, sbadame and amitmodak as code owners July 6, 2023 14:23

bhavanapalle2023 added 7 commits July 6, 2023 16:32

helm image files

885426c

Update README.md

e12e42b

Update mount_test.go

01c7cd9

tag to hash

076279c

tag to hash

fd86509

create Artifact repository

88396a6

Update mount_test.go

7b4245a

amitmodak reviewed Jul 7, 2023

View reviewed changes

bhavanapalle2023 added 6 commits July 10, 2023 09:15

Update README.md

aaadfcb

Removed the comment in cloudbuild-dev.yaml

4023393

Update Chart.yaml

334468b

version to app version cloudbuild-dev.yaml

ab22de2

version to appversion mount_test.go

18fe1ef

New line cloudbuild-dev.yaml

5a2b060

underscoreanuj reviewed Jul 17, 2023

View reviewed changes

underscoreanuj approved these changes Jul 17, 2023

View reviewed changes

bhavanapalle2023 added 2 commits July 17, 2023 11:19

removed inconsistent spaces between keywords - build.sh

87c45d1

inconsistent spaces runner.sh

f3c021f

Update build.sh

71f8e8f

amitmodak reviewed Jul 24, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helm chart #273

Add helm chart #273

bhavanapalle2023 commented Jul 6, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

amitmodak Jul 7, 2023

bhavanapalle2023 Jul 10, 2023

underscoreanuj Jul 17, 2023 •

edited

Loading

bhavanapalle2023 Jul 17, 2023

underscoreanuj Jul 17, 2023

amitmodak Jul 24, 2023

underscoreanuj left a comment

amitmodak Jul 24, 2023

amitmodak Jul 24, 2023

amitmodak Jul 24, 2023

		@@ -4,3 +4,7 @@ description: A Helm chart to install Google Secret Manager Provider for Secret S
		type: application
		version: 0.1.0

Add helm chart #273

Are you sure you want to change the base?

Add helm chart #273

Conversation

bhavanapalle2023 commented Jul 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

underscoreanuj Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

underscoreanuj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

underscoreanuj Jul 17, 2023 •

edited

Loading