Fix wrong GcpProjectIdProvider when using Secret Manager #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PatrickGotthard
force-pushed
the
fix-secretmanager-projectid
branch
from
ec6b588
to
1bb45e4
Compare
mieseprem
reviewed
Nov 20, 2024
...google/cloud/spring/autoconfigure/secretmanager/SecretManagerConfigDataLocationResolver.java
Outdated
Show resolved
Hide resolved
PatrickGotthard
force-pushed
the
fix-secretmanager-projectid
branch
from
1c67c38
to
94c7fe2
Compare
mieseprem
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Secret Manager module the GcpProjectIdProvider behaves incorrectly.
It will return the property spring.cloud.gcp.secretmanager.project-id or a DefaultGcpProjectIdProvider instead of spring.cloud.gcp.project-id. Also the SecretManagerConfigDataLocationResolver currently does not take the property spring.cloud.gcp.project-id into account.
This PR solves #3181