fix(kms): certificate chain type to array of strings #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:216fffd274b08af2e3f718d3d8aeb8cb6410b420] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-216fffd274b08af2e3f718d3d8aeb8cb6410b420
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response type for KeyOperationAttestation CertificateChains is an array of strings. This is also what documentation says. https://cloud.google.com/kms/docs/reference/rest/v1/KeyOperationAttestation#certificatechains
However the provider spec for that property lists them as strings, so terraform will panic whenever a key version is created with HSM that uses these certificates as the types are mismatched. This PR fixes this so the type is an array of strings, as well as adding an AccTest for HSM key version
Fixes hashicorp/terraform-provider-google#13924
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9582