-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added k8s manifests for cymbal bank frontend #68
Conversation
7c821b5
to
a2d7962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inital nits/suggestions
6-appsource/cymbal-bank/components/add-public-key-volume/add-public-key-volume.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/components/add-public-key-volume/kustomization.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/components/add-tmp-dir/add-tmp-dir.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/components/add-tmp-dir/kustomization.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/components/add-public-key-volume/kustomization.yaml
Show resolved
Hide resolved
6-appsource/cymbal-bank/frontend/k8s/overlays/production/frontend-service.yaml
Show resolved
Hide resolved
6-appsource/cymbal-bank/frontend/k8s/overlays/production/kustomization.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/frontend/k8s/overlays/staging/kustomization.yaml
Outdated
Show resolved
Hide resolved
6-appsource/cymbal-bank/components/cloud-sql/cloud-sql-proxy/add-container.yaml
Show resolved
Hide resolved
@apeabody i have to switch back component from v1beta1 to v1alpha1, as kustomize does not support v1beta1 for component. |
Interesting! - Although not ideal to depend on an Alpha API as they can be changed or removed at any time. |
/gcbrun |
No description provided.