Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added k8s manifests for cymbal bank frontend #68

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

yliaog
Copy link
Collaborator

@yliaog yliaog commented Apr 11, 2024

No description provided.

@yliaog yliaog requested review from gtsorbo and a team as code owners April 11, 2024 17:07
@yliaog yliaog force-pushed the k8s branch 3 times, most recently from 7c821b5 to a2d7962 Compare April 11, 2024 17:29
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inital nits/suggestions

@yliaog
Copy link
Collaborator Author

yliaog commented Apr 12, 2024

@apeabody i have to switch back component from v1beta1 to v1alpha1, as kustomize does not support v1beta1 for component.

@apeabody
Copy link
Collaborator

@apeabody i have to switch back component from v1beta1 to v1alpha1, as kustomize does not support v1beta1 for component.

Interesting! - Although not ideal to depend on an Alpha API as they can be changed or removed at any time.

@gtsorbo
Copy link
Collaborator

gtsorbo commented Apr 16, 2024

/gcbrun

@gtsorbo gtsorbo merged commit a0dda5c into GoogleCloudPlatform:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants